Bug 440259

Link

Cause: QN-ItQ

  • Evidence: "User::match calls Bugzilla::User::new in a loop instead of using new_from_list, which could mean 1000 SQL calls, one right after another, instead of just one", comment 1

Fix: CQ

  • Evidence: In the patch, changed from calling Bugzilla::User::new in a loop to just one call of Bugzilla::User->new_from_list

Interesting Finding: Proposed Patch is DBMS-Dependent

  • Evidence: "I have to back out this patch. PostgreSQL complains that we ORDER BY login_name despite we don't list login_name in SELECT DISTINCT.", comment 13