循環點亮LED_迴圈寫法

/* Sketch was generated by motoblockly  Website: http://www.motoblockly.com  Author: www.motoduino.com  Date: Wed Oct 30 2024 11:36:43 GMT+0800 */ int i=0;int pin=-1;
void setup(){  for (int i = 0; i <= 9; i=i+1) {    pin = pin + 1;    pinMode(pin,OUTPUT);  }
}

void loop(){  for (int pin = 0; pin <= 9; pin=pin+1) {    digitalWrite(pin,HIGH);    delay(50);    digitalWrite(pin,LOW);    delay(50);  }  for (int pin = 9; pin >= 0; pin=pin-1) {    digitalWrite(pin,HIGH);    delay(50);    digitalWrite(pin,LOW);    delay(50);  }

}

/* 使用A3與A4下拉式電阻，控制16顆LED前進與後退亮燈 */
int button_count1 = 0; //A3按鈕計數int button_count2 = 0; //A4按鈕計數int led1 = 22;  int led2 = 21;int led3 = 23;  void setup()
{  pinMode(22, OUTPUT);  pinMode(23, OUTPUT);  pinMode(24, OUTPUT);  pinMode(25, OUTPUT);  pinMode(26, OUTPUT);  pinMode(27, OUTPUT);  pinMode(28, OUTPUT);  pinMode(29, OUTPUT);  pinMode(30, OUTPUT);  pinMode(31, OUTPUT);  pinMode(32, OUTPUT);  pinMode(33, OUTPUT);  pinMode(34, OUTPUT);  pinMode(35, OUTPUT);  pinMode(36, OUTPUT);  pinMode(37, OUTPUT);  pinMode(A2, INPUT);  pinMode(A3, INPUT);}
void loop(){  if (digitalRead(A2) == 0 && button_count1 == 0) {    digitalWrite(led1, HIGH);    digitalWrite(led2, LOW);    digitalWrite(led3, LOW);    button_count1 = 1;  }
  if (digitalRead(A2) == 1 && button_count1 == 1) {    led1 = led1 + 1;    led2 = led2 + 1;    led3 = led3 + 1;    button_count1 = 0;   if (led1 >= 37) { // 限制最大值    led1 = 37;    led2 = 36;    led3 = 38;   }  }  if (digitalRead(A3) == 0 && button_count2 == 0) {    digitalWrite(led1, HIGH);    digitalWrite(led2, LOW);    digitalWrite(led3, LOW);    button_count2 = 1;  }
  if (digitalRead(A3) == 1 && button_count2 == 1) {    led1 = led1 - 1;    led2 = led2 - 1;    led3 = led3 - 1;    button_count2 = 0;   if (led1 <= 22) { // 限制最小值    led1 = 22;    led2 = 21;    led3 = 23;   }  }  delay(10); // Delay a little bit to improve simulation performance}

/* 這段程式碼的目的是透過兩個按鈕（接在 A2 和 A3 腳位）來控制三個 LED 的亮燈位置，並可向上或向下移動 LED 的位置。🔘 按鈕邏輯A2 按鈕（向上移動 LED）按下時（digitalRead(A2) == 0）點亮目前的 LED 組合。放開時（digitalRead(A2) == 1）將三個 LED 腳位加 1，並重設按鈕狀態。若超過最大值（led1 >= 37），則限制在 37、36、38。A3 按鈕（向下移動 LED）按下時點亮目前 LED。放開時將三個 LED 腳位減 1。若低於最小值（led1 <= 22），則限制在 22、21、23。⚠️ 問題與可改進之處LED 腳位未全部初始化：程式中使用了 led1, led2, led3 變動腳位，但 pinMode() 只初始化了固定腳位，可能導致某些 LED 腳位未設定為輸出。按鈕去彈跳（Debounce）未處理：按鈕在物理上可能會抖動，導致誤判。建議加入延遲或狀態判斷。程式可讀性與維護性不佳：建議使用函式來簡化 LED 控制邏輯，並使用陣列管理 LED 腳位。🛠 改進重點使用 millis() 處理去彈跳，避免誤判。用 for 迴圈初始化所有可能用到的 LED 腳位。將 LED 控制邏輯封裝成 lightUpLEDs() 函式，提升可讀性。使用 INPUT_PULLUP 讓按鈕接地即可觸發，簡化硬體設計。*/
const int ledMin = 22;const int ledMax = 37;
int led1 = 22;int led2 = 21;int led3 = 23;
int buttonA2State = 0;int buttonA3State = 0;
unsigned long lastDebounceTime = 0;const unsigned long debounceDelay = 50;
void setup() {  for (int i = ledMin - 1; i <= ledMax + 1; i++) {    pinMode(i, OUTPUT);  }  pinMode(A2, INPUT_PULLUP);  pinMode(A3, INPUT_PULLUP);}
void loop() {  int readA2 = digitalRead(A2);  int readA3 = digitalRead(A3);
  // A2 按鈕邏輯（向上）  if (readA2 == LOW && buttonA2State == 0 && millis() - lastDebounceTime > debounceDelay) {    lightUpLEDs();    buttonA2State = 1;    lastDebounceTime = millis();  }
  if (readA2 == HIGH && buttonA2State == 1 && millis() - lastDebounceTime > debounceDelay) {    led1++;    led2++;    led3++;    if (led1 >= ledMax) {      led1 = ledMax;      led2 = ledMax - 1;      led3 = ledMax + 1;    }    buttonA2State = 0;    lastDebounceTime = millis();  }
  // A3 按鈕邏輯（向下）  if (readA3 == LOW && buttonA3State == 0 && millis() - lastDebounceTime > debounceDelay) {    lightUpLEDs();    buttonA3State = 1;    lastDebounceTime = millis();  }
  if (readA3 == HIGH && buttonA3State == 1 && millis() - lastDebounceTime > debounceDelay) {    led1--;    led2--;    led3--;    if (led1 <= ledMin) {      led1 = ledMin;      led2 = ledMin - 1;      led3 = ledMin + 1;    }    buttonA3State = 0;    lastDebounceTime = millis();  }
  delay(10);}
void lightUpLEDs() {  for (int i = ledMin - 1; i <= ledMax + 1; i++) {    digitalWrite(i, LOW);  }  digitalWrite(led1, HIGH);  digitalWrite(led2, LOW);  digitalWrite(led3, LOW);}

Page updated

Google Sites

Report abuse