The tips below are distilled from a lot of time spent writing character-provided tournament scenarios. They cover a lot of "best-practices" stuff, as well as warning you away from all-too-common "worst-practices".
Fun
- Sense of Adventure
- Scenario Not Out To Get Them
- Interesting & Different
- Good Rewards
- Exciting Pace
Fair
- Each Character is "Winnable"
- Each Character Has Equal Importance to the Scenario
- Setting/Background in Explainable in 15 Minutes
Consistent
- No Anachronisms
- Fits the Campaign Setting
- Fits the Game System
- Internally Consistent
- Just Makes Sense
Well-Produced
- Spell-Checked
- Edited
- No Missing Maps/Handouts
- Read-Aloud Text is Readable
- Formatted Correctly