Review

Once the coding is done, the reviewers must review the code. Reviews are important, to identify issues missed by the developer and ensure good quality code. Specifically, the reviewer should:

1. Check if the code is mergeable with the master branch without any conflicts. Whenever a pull request is created, GitHub automatically shows the conflicts, if there are any.

2. Then, carefully review the code to check if the code implements the intended functionality.

3. Check if the code is readable and documented properly.

4. Next, make sure that the new code doesn't break existing functionalities and does not have potential side effects.

5. Next, make sure the code is accompanied by unit tests and performance tests (if necessary). Also, verify that unit tests are written to cover all the possible scenarios.

6. Then, verify that all tests pass and the tests cover all lines of the code.

7. Next, make sure the coding style is adhered to.

If there are any problems, provide review comments to the developer. Otherwise, merge the code (or instruct the developer to merge the code) with the master branch.

Resources

Best Practices for Code Review